-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to 1ES build pools release/dev17.0 #56186
Switch to 1ES build pools release/dev17.0 #56186
Conversation
ef6e259
to
314029d
Compare
@jonfortescue Are these Windows Server Core instances? From failed integration tests:
|
Ooh good question. @ulisesh can you tell us more about the composition of these pools? |
The new image should be the same as the one we had in Helix buildpools, I don't think they are Server Core images. @jonfortescue can you confirm this with Casey? |
@ulisesh Casey confirmed that this is running Windows Server Datacenter. I have no idea why we're getting these errors. |
Crazy thought... could it be possible that the test expects the user to be vsagent? The new pools use cloudtest and the error says |
I still believe is something related to UI on these new machines. Here's the inner exception:
|
27bb6ee
to
8f59392
Compare
Solution was to turn interactive mode on in the pool properties. Done, and seems to be working now. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
We had to disable interactive mode because it caused an issue with provisioning machines. 1ES is investigating it but this PR is blocked until the issue is solved. |
Everything green on the int machines. Once we rollout, this should be good to merge. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@JoeRobich have you ever seen these failures in the integration tests before? They are new as I wasn't seeing them when testing in int last week. |
@jonfortescue Those typically indicate that we need to bump our global.json pinned sdk version. In this case we should move to RC2. cc: @RikkiGibson |
@JoeRobich all checks passing. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per changes we're making here https://github.com/dotnet/core-eng/issues/14276, we need to migrate to 1ES build pools so this does that.
internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1342339&view=results