Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 1ES build pools release/dev17.0 #56186

Merged
merged 11 commits into from
Oct 22, 2021

Conversation

jonfortescue
Copy link
Contributor

@jonfortescue jonfortescue commented Sep 3, 2021

Per changes we're making here https://github.com/dotnet/core-eng/issues/14276, we need to migrate to 1ES build pools so this does that.

internal build: https://dev.azure.com/dnceng/internal/_build/results?buildId=1342339&view=results

@sharwell sharwell marked this pull request as draft September 9, 2021 17:28
@JoeRobich
Copy link
Member

@jonfortescue Are these Windows Server Core instances?

From failed integration tests:

Screenshot failed; attempting to connect to the console
No User exists for cloudtest
tscon  /dest:console
Invalid parameter(s)
Attaches a user session to a remote desktop session.

TSCON {sessionid | sessionname} [/DEST:sessionname]
        [/PASSWORD:pw | /PASSWORD:*] [/V]

  sessionid          The ID of the session.
  sessionname        The name of the session.
  /DEST:sessionname  Connect the session to destination sessionname.
  /PASSWORD:pw       Password of user owning identified session.
  /V                 Displays information about the actions performed.

No User exists for *
Exception calling "CopyFromScreen" with "6" argument(s): "The handle is invalid"
System.Management.Automation.MethodInvocationException: Exception calling "CopyFromScreen" with "6" argument(s): "The handle is invalid" ---> System.ComponentModel.Win32Exception: The handle is invalid
   at System.Drawing.Graphics.CopyFromScreen(Int32 sourceX, Int32 sourceY, Int32 destinationX, Int32 destinationY, Size blockRegionSize, CopyPixelOperation copyPixelOperation)
   at CallSite.Target(Closure , CallSite , Object , Object , Object , Int32 , Int32 , Object , CopyPixelOperation )
   --- End of inner exception stack trace ---
   at System.Management.Automation.ExceptionHandlingOps.CheckActionPreference(FunctionContext funcContext, Exception exception)
   at System.Management.Automation.Interpreter.ActionCallInstruction`2.Run(InterpretedFrame frame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
   at System.Management.Automation.Interpreter.EnterTryCatchFinallyInstruction.Run(InterpretedFrame frame)
at Capture-Screenshot, D:\a\_work\1\s\eng\build-utils-win.ps1: line 17
at Setup-IntegrationTestRun, D:\a\_work\1\s\eng\build.ps1: line 634
at <ScriptBlock>, D:\a\_work\1\s\eng\build.ps1: line 687
at <ScriptBlock>, D:\a\_work\_temp\78ec8d4c-f8e6-4d4f-bbf2-87d19cb8324c.ps1: line 3
at <ScriptBlock>, <No file>: line 1

@jonfortescue
Copy link
Contributor Author

Ooh good question. @ulisesh can you tell us more about the composition of these pools?

@ulisesh
Copy link

ulisesh commented Sep 13, 2021

The new image should be the same as the one we had in Helix buildpools, I don't think they are Server Core images. @jonfortescue can you confirm this with Casey?

@jonfortescue
Copy link
Contributor Author

@ulisesh Casey confirmed that this is running Windows Server Datacenter. I have no idea why we're getting these errors.

@ulisesh
Copy link

ulisesh commented Sep 13, 2021

Crazy thought... could it be possible that the test expects the user to be vsagent? The new pools use cloudtest and the error says No User exists for cloudtest

@jonfortescue
Copy link
Contributor Author

I still believe is something related to UI on these new machines. Here's the inner exception:

System.AggregateException: One or more errors occurred. ---> System.InvalidOperationException: Failed to set the foreground window.
   at Microsoft.VisualStudio.IntegrationTest.Utilities.IntegrationHelper.SetForegroundWindow(IntPtr window) in /_/src/VisualStudio/IntegrationTest/TestUtilities/IntegrationHelper.cs:line 218
   at Microsoft.VisualStudio.IntegrationTest.Utilities.InProcess.VisualStudio_InProc.<>c.<ActivateMainWindow>b__7_0(CancellationToken cancellationToken) in /_/src/VisualStudio/IntegrationTest/TestUtilities/InProcess/VisualStudio_InProc.cs:line 66
   at Microsoft.VisualStudio.IntegrationTest.Utilities.InProcess.InProcComponent.<>c__DisplayClass6_0.<<InvokeOnUIThread>b__0>d.MoveNext() in /_/src/VisualStudio/IntegrationTest/TestUtilities/InProcess/InProcComponent.cs:line 57
   --- End of inner exception stack trace ---

@jonfortescue
Copy link
Contributor Author

Solution was to turn interactive mode on in the pool properties. Done, and seems to be working now.

@jonfortescue
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@lpatalas
Copy link

We had to disable interactive mode because it caused an issue with provisioning machines. 1ES is investigating it but this PR is blocked until the issue is solved.

@jonfortescue
Copy link
Contributor Author

Everything green on the int machines. Once we rollout, this should be good to merge.

@jonfortescue jonfortescue marked this pull request as ready for review October 13, 2021 15:41
@jonfortescue
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jonfortescue
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jonfortescue jonfortescue changed the title Use 1ES build pools Switch to 1ES build pools release/dev17.0 Oct 20, 2021
@jonfortescue
Copy link
Contributor Author

@JoeRobich have you ever seen these failures in the integration tests before? They are new as I wasn't seeing them when testing in int last week.

@JoeRobich
Copy link
Member

@jonfortescue Those typically indicate that we need to bump our global.json pinned sdk version. In this case we should move to RC2. cc: @RikkiGibson

@jonfortescue
Copy link
Contributor Author

@JoeRobich all checks passing. :)

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jonfortescue jonfortescue merged commit f224969 into dotnet:release/dev17.0 Oct 22, 2021
@jonfortescue jonfortescue deleted the 1esPools170 branch October 22, 2021 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants