Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

semi auto properties: Address feedback of previous PR #58519

Merged
merged 1 commit into from
Dec 29, 2021
Merged

semi auto properties: Address feedback of previous PR #58519

merged 1 commit into from
Dec 29, 2021

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 29, 2021 •
edited
Loading

@Youssef1313 Youssef1313 requested a review from a team as a code owner December 29, 2021 07:22
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Dec 29, 2021
@Youssef1313
Copy link
Member Author

Test failure is #34207

This was referenced Dec 29, 2021
Closed
Closed
AlekseyTs
AlekseyTs approved these changes Dec 29, 2021
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1)

@AlekseyTs
Copy link
Contributor

@333fred, @dotnet/roslyn-compiler For the second review.

@333fred 333fred merged commit 83b7470 into dotnet:features/semi-auto-props Dec 29, 2021
@333fred
Copy link
Member

333fred commented Dec 29, 2021

Thanks @Youssef1313!

@Youssef1313 Youssef1313 deleted the semi-feedback branch December 30, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @AlekseyTs @333fred