Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Roslyn Diagnostic Window and add Workspace panel #59035

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Fix Roslyn Diagnostic Window and add Workspace panel #59035

merged 1 commit into from
Jan 28, 2022

Conversation

tmat
Copy link
Member

@tmat tmat commented Jan 24, 2022 •
edited
Loading

A couple of issues:

  • ProvideToolWindow attribute was missing
  • PerfMargin.DataModel was incorrectly indexing into array

@tmat tmat requested a review from a team as a code owner January 24, 2022 01:25
@ghost ghost added the Needs UX Triage label Jan 24, 2022
@runfoapp runfoapp bot mentioned this pull request Jan 24, 2022
Closed
ryzngard
ryzngard approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@ryzngard ryzngard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think I understand what the issue was, but a description wouldn't hurt :)

@tmat tmat enabled auto-merge (squash) January 27, 2022 22:31
@runfoapp runfoapp bot mentioned this pull request Jan 28, 2022
Closed
@tmat tmat merged commit 7f51127 into dotnet:main Jan 28, 2022
@ghost ghost added this to the Next milestone Jan 28, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.2.P1 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
Area-IDE
Projects
None yet
Milestone
17.2.P1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @ryzngard @RikkiGibson