Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompletionService refactoring and small tweaks to import completion #59125

Merged
merged 22 commits into from
Feb 3, 2022
Merged

CompletionService refactoring and small tweaks to import completion #59125

merged 22 commits into from
Feb 3, 2022

Commits on Jan 6, 2022

  1. Small cleanup in CompletionSource and CompletionService

    @genlu
    genlu committed Jan 6, 2022
    Configuration menu
    Copy the full SHA
    04b3c78 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2022

  1. Add ExpandItemsAvailable flag in CompletionList 

    And minor cleanup in CompletionService APIs where CompletionList is used
    @genlu
    genlu committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    e497b35 View commit details
    Browse the repository at this point in the history

  2. Small cleanup of context iteration/aggregation

    @genlu
    genlu committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    76ea805 View commit details
    Browse the repository at this point in the history

  3. Move provider handling into a helper class

    @genlu
    genlu committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    c203032 View commit details
    Browse the repository at this point in the history

  4. File rename

    @genlu
    genlu committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    5bb4567 View commit details
    Browse the repository at this point in the history

  5. More minor cleanup in CompletionServiceWithProviders

    @genlu
    genlu committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    d88f72c View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Remove timebox for unimported extension method completion provider

    @genlu
    genlu committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    3478436 View commit details
    Browse the repository at this point in the history

  2. Don't block completion expander on index creation

    @genlu
    genlu committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    25293b9 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. Reduce allocation 

    by setting capacity of the builder to avoid call to EnsureCapacity
    @genlu
    genlu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a69ac01 View commit details
    Browse the repository at this point in the history

  2. Simplify code

    @genlu
    genlu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    dc9a8f0 View commit details
    Browse the repository at this point in the history

  3. Always show expander in filter list

    @genlu
    genlu committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    ccf660a View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Simplify how "expanded completion" is controlled 

    Instead of passing in a boolean to indicated if its triggered by selecting expander button, now import completion providers only need to check if import completion is enabled.
    @genlu
    genlu committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    afb54b4 View commit details
    Browse the repository at this point in the history

  2. Pass in CompletionOptions to CompletionSource worker method

    @genlu
    genlu committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    3cf6e20 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Use record struct

    @genlu
    genlu committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    a4cf108 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Merge remote-tracking branch 'dotnet/main' into refactoring

    @genlu
    genlu committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    08a3385 View commit details
    Browse the repository at this point in the history

  2. Fix completion trigger 

    Was broken by previous refactoring
    @genlu
    genlu committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    b099904 View commit details
    Browse the repository at this point in the history

  3. Return partial result for unimported types completion when cache miss

    @genlu
    genlu committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    aac47aa View commit details
    Browse the repository at this point in the history

  4. Add test only options for import completion 

    So we can always wait for unimported items and force index creation
    @genlu
    genlu committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    1235a42 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Clean up telemetry

    @genlu
    genlu committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    f06e2ab View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2022

  1. Fix

    @genlu
    genlu committed Jan 31, 2022
    Configuration menu
    Copy the full SHA
    217ae3b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Merge remote-tracking branch 'dotnet/main' into CompletionRefactoring

    @genlu
    genlu committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    a504005 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @genlu
    genlu committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    817f5d8 View commit details
    Browse the repository at this point in the history