Remove netstandard1.3 from code base #59177
Conversation
The remote debugger components moved to their minimum framework install to 4.6.2 where it was previously 2.0. That means we can remove the uses of `netstandard1.3` in our code base as they existed just to support this specific case. This means we can also remove our use of `net2.0` in the code base and replace it with `net462`. That is a more involved changed though and going to take that a piece at a time. Removing `netstandard1.3` is an important step because presently it's blocking us from updating to the latest System.Collections.Immutable as it dropped support for `netstandard1.3`
|
@dotnet/roslyn-infrastructure, @tmat PTAL |
src/Dependencies/CodeAnalysis.Debugging/Microsoft.CodeAnalysis.Debugging.Package.csproj
Outdated
Show resolved
Hide resolved
|
Test insertion - https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/376937 (microsoft) |
|
@RikkiGibson verified offline with @333fred that the VS test run didn't reveal any issues hence think you are safe to remove your "request changes" now. If there are other checks you think we should run please let me know. |
RikkiGibson
dismissed
their stale review
I don't object to merging, though my preference would be to wait for after the 17.2-p1 snap (mid-day tomorrow).
|
@dotnet/roslyn-infrastructure, @dotnet/roslyn-ide can i get a second review here? This is impacting the ability for VS Plat to upgrade S.C.I |
There was a problem hiding this comment.
I believe we snapped for 17.2p2 at this point @RikkiGibson?
We hadn't at the time of this comment, but now we have. |
|
Merge at will :) |
ghost
added this to the
|
Let's see how this goes ... |
The remote debugger components moved to their minimum framework install
to 4.6.2 where it was previously 2.0. That means we can remove the uses
of
netstandard1.3in our code base as they existed just to supportthis specific case.
This means we can also remove our use of
net2.0in the code base andreplace it with
net462. That is a more involved changed though andgoing to take that a piece at a time. Removing
netstandard1.3is animportant step because presently it's blocking us from updating to the
latest System.Collections.Immutable as it dropped support for
netstandard1.3