Classify pattern variables

[alrz]

Fixes #59484

[Youssef1313]

@alrz Can you merge the latest main and run this test locally:

roslyn/src/EditorFeatures/CSharpTest/Classification/SyntacticClassifierTests.cs

Lines 5109 to 5125 in 220b3eb

	[Theory]
	[CombinatorialData]
	[WorkItem(18956, "https://github.com/dotnet/roslyn/issues/18956")]
	public async Task TestVarPattern(TestHost testHost)
	{
	await TestInMethodAsync(@"
	_ = 1 is var x;
	",
	testHost,
	Identifier("_"),
	Operators.Equals,
	Number("1"),
	Keyword("is"),
	Keyword("var"),
	Identifier("x"),
	Punctuation.Semicolon);
	}

I think it will fail (Identifier("x") should be Local("x")), then you need to update it.

This test didn't exist when you first opened the PR.

[sharwell]

I don't see an issue here but @CyrusNajmabadi should double check

[alrz]

@alrz Can you merge the latest main and run this test locally

Thanks for the pointer. I'll take a look.

[alrz]

Failures seem to be unrelated. @CyrusNajmabadi

[alrz]

ping @CyrusNajmabadi (looks like one check is still blocking)

[CyrusNajmabadi]

We're having issues with ci. Likely won't be able to merge until Monday unless someone can fix that.

[alrz]

@CyrusNajmabadi Should I sync this with main? Yeah I do.. Didn't see the conflict on my phone.

[alrz]

We're having issues with ci. Likely won't be able to merge until Monday unless someone can fix that.

It's been quite a few Mondays since the last time, still not green. :(

[Youssef1313]

@alrz The current failure is roslyn-integration-corehost which isn't required for merge. It should be okay to merge as is now.

@CyrusNajmabadi Can you merge please?

[CyrusNajmabadi]

Thanks!