Follow up on Test Plan Review and PROTOTYPE comments for UTF8 String Literals feature. #60349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Literals feature. - Define and implement IUTF8StringOperation node. - Disallow UTF8StringLiteral conversion for default parameter value. - Add tests
AlekseyTs
force-pushed
the
Utf8StringLiterals_19
branch
from
268e5f9
to
2149684
Compare
|
@cston, @RikkiGibson, @dotnet/roslyn-compiler Please review. |
This was referenced Mar 24, 2022
|
@cston, @RikkiGibson, @dotnet/roslyn-compiler Please review. |
RikkiGibson
approved these changes
Mar 24, 2022
| @@ -3273,4 +3273,20 @@ | |||
| </Comments> | |||
| </Property> | |||
| </Node> | |||
| <Node Name="IUTF8StringOperation" Base="IOperation" HasType="true" HasConstantValue="false"> | |||
There was a problem hiding this comment.
Has this gone through API review?
There was a problem hiding this comment.
Has this gone through API review?
Not yet.
|
@cston, @dotnet/roslyn-compiler For the second review. |
cston
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan #58848