Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FixAll support for code refactorings (approach #2) #60906

Merged
merged 38 commits into from
Apr 29, 2022
Merged

Add FixAll support for code refactorings (approach #2) #60906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
d9f5725
FixAll public API + core fix all related types + other workspace rela…
mavasani Feb 28, 2022
7812bec
Features layer changes for FixAll support for refactorings
mavasani Feb 28, 2022
26c35ef
Unified suggestion related changes for FixAll support for refactorings
mavasani Feb 28, 2022
c6cc64f
EditorFeatures layer changes for FixAll support for refactorings
mavasani Feb 28, 2022
4630883
VisualStudio layer changes for FixAll support for refactorings
mavasani Feb 28, 2022
96cd412
Proof of concept - "Invert conditional" code refactoring enhancement …
mavasani Feb 28, 2022
f73b283
Merge remote-tracking branch 'upstream/main' into FixAllCodeRefactoring
mavasani Apr 11, 2022
c1adefd
Remove FixAllScope.Selection
mavasani Apr 11, 2022
b463620
Nullable enable
mavasani Apr 11, 2022
b41f729
Share code
mavasani Apr 11, 2022
7ef03b2
Add code refactoring specific API to IFixAllSpanMappingService and up…
mavasani Apr 12, 2022
80dc735
Cleanup to make the APIs consistent with FixAll APIs for code fixes
mavasani Apr 12, 2022
6e86cd6
Make FixAll APIs for refactorings internal for now. #60703 tracks mak…
mavasani Apr 12, 2022
b27b6ca
Fix function ID
mavasani Apr 12, 2022
09d595c
Fixes
mavasani Apr 12, 2022
b2b7cf8
Add unit tests and integration tests
mavasani Apr 13, 2022
4f20ef8
Add integration test support for FixAll for code refactorings and fix…
mavasani Apr 14, 2022
d97f240
Merge remote-tracking branch 'upstream/main' into FixAllCodeRefactoring
mavasani Apr 14, 2022
bd85c93
Fixes from merge
mavasani Apr 14, 2022
a1e77fe
Fix IDE0044
mavasani Apr 14, 2022
38d73f3
Add FixAll support for code refactorings
mavasani Apr 22, 2022
27c54a2
Merge remote-tracking branch 'upstream/main' into FixAllCodeRefactori…
mavasani Apr 22, 2022
3500a61
Cleanup
mavasani Apr 22, 2022
3b92633
Cleanup
mavasani Apr 22, 2022
6786c47
Cleanup
mavasani Apr 22, 2022
824012d
Cleanup
mavasani Apr 22, 2022
3fe5ebb
Comment
mavasani Apr 22, 2022
a4b67fd
Merge branch 'FixAllCodeRefactoring_2' of https://github.com/mavasani…
mavasani Apr 22, 2022
8bd4f16
Revert
mavasani Apr 22, 2022
3a311d0
Revert
mavasani Apr 22, 2022
9c6489f
Revert
mavasani Apr 22, 2022
fa6fab7
Revert
mavasani Apr 22, 2022
c871783
Share more code
mavasani Apr 22, 2022
a154a24
Refactor
mavasani Apr 22, 2022
00efaed
Fix warning
mavasani Apr 22, 2022
a54ee1d
Address feedback
mavasani Apr 26, 2022
98e8d83
Merge remote-tracking branch 'upstream/main' into FixAllCodeRefactori…
mavasani Apr 27, 2022
265022a
Address feedback - do not parse/load text for documents
mavasani Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...rAndNamespace/AbstractChangeNamespaceToMatchFolderCodeFixProvider.CustomFixAllProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
using System.Threading;
using System.Threading.Tasks;
using Microsoft.CodeAnalysis.CodeActions;
using Microsoft.CodeAnalysis.CodeFixesAndRefactorings;
using Microsoft.CodeAnalysis.Shared.Extensions;
using Microsoft.CodeAnalysis.Shared.Utilities;
using Roslyn.Utilities;
Expand Down Expand Up @@ -39,7 +40,7 @@ private class CustomFixAllProvider : FixAllProvider
if (diagnostics.IsDefaultOrEmpty)
return null;

var title = FixAllContextHelper.GetDefaultFixAllTitle(fixAllContext);
var title = fixAllContext.GetDefaultFixAllTitle();
return CodeAction.Create(
title,
cancellationToken => FixAllByDocumentAsync(
Expand Down
6 changes: 3 additions & 3 deletions src/EditorFeatures/CSharpTest/CodeActions/Preview/PreviewExceptionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ private static async Task GetPreview(TestWorkspace workspace, CodeRefactoringPro
var suggestedAction = new CodeRefactoringSuggestedAction(
workspace.ExportProvider.GetExportedValue<IThreadingContext>(),
workspace.ExportProvider.GetExportedValue<SuggestedActionsSourceProvider>(),
workspace, textBuffer, provider, codeActions.First());
workspace, textBuffer, provider, codeActions.First(), fixAllFlavors: null);
await suggestedAction.GetPreviewAsync(CancellationToken.None);
Assert.True(extensionManager.IsDisabled(provider));
Assert.False(extensionManager.IsIgnored(provider));
Expand All @@ -85,7 +85,7 @@ private static void DisplayText(TestWorkspace workspace, CodeRefactoringProvider
var suggestedAction = new CodeRefactoringSuggestedAction(
workspace.ExportProvider.GetExportedValue<IThreadingContext>(),
workspace.ExportProvider.GetExportedValue<SuggestedActionsSourceProvider>(),
workspace, textBuffer, provider, codeActions.First());
workspace, textBuffer, provider, codeActions.First(), fixAllFlavors: null);
_ = suggestedAction.DisplayText;
Assert.True(extensionManager.IsDisabled(provider));
Assert.False(extensionManager.IsIgnored(provider));
Expand All @@ -98,7 +98,7 @@ private static async Task ActionSets(TestWorkspace workspace, CodeRefactoringPro
var suggestedAction = new CodeRefactoringSuggestedAction(
workspace.ExportProvider.GetExportedValue<IThreadingContext>(),
workspace.ExportProvider.GetExportedValue<SuggestedActionsSourceProvider>(),
workspace, textBuffer, provider, codeActions.First());
workspace, textBuffer, provider, codeActions.First(), fixAllFlavors: null);
_ = await suggestedAction.GetActionSetsAsync(CancellationToken.None);
Assert.True(extensionManager.IsDisabled(provider));
Assert.False(extensionManager.IsIgnored(provider));
Expand Down
Loading