Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EA layer for ASP.NET Core. #60948
Add EA layer for ASP.NET Core. #60948
Changes from all commits
05babf3
7d472e2
52834c9
ca267b2
1d5a1ee
6ec7787
7ce48e8
3546034
18a2f6b
7273e7e
a4ebcb9
e9bb1bd
f8733b9
697b37e
7f85421
940163c
d487222
ffac814
b367814
a724dc7
854deef
171255c
28fce58
5f7cc41
134cd74
b3b6d4d
62468e7
e63c46d
0247986
6e8ebd5
04af109
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, should be
RestrictedInternalsVisibleTo
similar to two lines above, otherwise this is just a regular IVT with access to full internal surface area, and having an ExternalAccess layer serves no purpose.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hrmm... i couldn't get thsi to work. are you sure that's the right pattern here? i'm creating a new EA lib that should have IVT to our libs. but it's that lib htat we can then audit to make sure it is not further exposing things outwards that it shoudln't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➡️
RestrictedInternalsVisibleTo
is only applicable to cases where we cannot create a new assembly. (marking unresolved just for visibility)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.