Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't initialize the StackTraceExplorer tool window until it is invoked #60973

Merged
merged 1 commit into from
Apr 27, 2022

Conversation

ryzngard
Copy link
Contributor

@ryzngard ryzngard commented Apr 26, 2022

Fixes AB#1524181

Tested locally and command invocation works as expected. The initialization was causing package loads while the Roslyn package was initializing. We can wait until needed, and likely those packages are loaded by then anyways.

@ryzngard ryzngard requested a review from a team as a code owner April 26, 2022 23:45
@ryzngard ryzngard enabled auto-merge (squash) April 27, 2022 00:28
@ryzngard ryzngard merged commit fb2d206 into dotnet:main Apr 27, 2022
@ghost ghost added this to the Next milestone Apr 27, 2022
@jinujoseph
Copy link
Contributor

@ryzngard we should port this to 17.3.Preview1

@ryzngard ryzngard deleted the perf/ste_initialize branch April 27, 2022 21:29
ryzngard added a commit to ryzngard/roslyn that referenced this pull request Apr 27, 2022
…ed (dotnet#60973)

Fixes AB#1524181

Tested locally and command invocation works as expected. The initialization was causing package loads while the Roslyn package was initializing. We can wait until needed, and likely those packages are loaded by then anyways.
ryzngard added a commit to ryzngard/roslyn that referenced this pull request Apr 27, 2022
…ed (dotnet#60973)

Fixes AB#1524181

Tested locally and command invocation works as expected. The initialization was causing package loads while the Roslyn package was initializing. We can wait until needed, and likely those packages are loaded by then anyways.
@RikkiGibson RikkiGibson modified the milestones: Next, 17.3 P3 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants