-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency versions for 4.2.0 publishing #61265
Conversation
Updates our nuget versions for 4.2.0, so that all published binaries will depend on publicly-available non-prerelease packages. As part of this, I had to break add multiple versions of MSBuild, as Microsoft.VisualStudio.Shell.15.0 is now advertising their dependency on MSBuild 17.1.0. There was always an indirect dependency there, but it was not included in their nuspec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
netcoreapp3.1
is an out of support runtime. We should not be complicating our build to support it. Literally every other .NET team is removing this TF. We should not be the outlier because it will long term result in us hacking our build over and over again.
This reverts commit a262f14.
@@ -5,7 +5,7 @@ | |||
<OutputType>Library</OutputType> | |||
<RootNamespace>Microsoft.CodeAnalysis</RootNamespace> | |||
<AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
<TargetFrameworks>netcoreapp3.1;net472</TargetFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source changes in this project are to deal with newly annotated APIs.
Withdrawing approval due to removal of a previously supported TFM, which has always been extremely frustrating to me as a user
Are we considering the move from 3.1 to .Net 6 in main? |
/azp run roslyn-integration-CI |
Azure Pipelines successfully started running 1 pipeline(s). |
Updates our nuget versions for 4.2.0, so that all published binaries will depend on publicly-available non-prerelease packages. As part of this, I had to break add multiple versions of MSBuild, as Microsoft.VisualStudio.Shell.15.0 is now advertising their dependency on MSBuild 17.1.0. There was always an indirect dependency there, but it was not included in their nuspec.