Implement concatenation operator for "u8" literals. #62044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @davidwengier This is a small addition to the "UTF8 Literals" feature. Please let me know if you have any concerns regarding impact on IDE. Are there any specific IDE tests I should add? |
|
Thanks, I don't think this introduces any concerns or new test areas for IDE |
|
@RikkiGibson, @cston, @dotnet/roslyn-compiler Please review. |
|
@RikkiGibson, @cston, @dotnet/roslyn-compiler For the second review. |
cston
reviewed
Jun 21, 2022
| CompileAndVerify(comp, expectedOutput: @"called", verify: Verification.Fails).VerifyDiagnostics(); | ||
| } | ||
|
|
||
| [ConditionalFact(typeof(CoreClrOnly))] |
There was a problem hiding this comment.
[Fact], here and similar tests below?
Perhaps tests with private implementation of ReadOnlySpan can be adjusted this way.
cston
approved these changes
Jun 21, 2022
ghost
added this to the 
|
Thanks! |
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet/csharplang#6221
Relates to test plan #58848