-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EnC] Allow renaming methods, properties, events etc. #62364
Conversation
src/EditorFeatures/Test/EditAndContinue/EditAndContinueWorkspaceServiceTests.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/Test/EditAndContinue/EditAndContinueWorkspaceServiceTests.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Features/Core/Portable/EditAndContinue/AbstractEditAndContinueAnalyzer.cs
Outdated
Show resolved
Hide resolved
Rather than create a third PR with mostly the same commits, I've cheekily added active statement checking to this one. Sorry, not sorry 😛 |
@@ -190,6 +190,9 @@ internal EmitBaseline GetDelta(Compilation compilation, Guid encId, MetadataSize | |||
// otherwise members from the current compilation have already been merged into the baseline. | |||
var synthesizedMembers = (_previousGeneration.Ordinal == 0) ? module.GetAllSynthesizedMembers() : _previousGeneration.SynthesizedMembers; | |||
|
|||
Debug.Assert(module.EncSymbolChanges is not null); | |||
var deletedMembers = (_previousGeneration.Ordinal == 0) ? module.EncSymbolChanges.GetAllDeletedMethods() : _previousGeneration.DeletedMembers; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't do this originally because it is not needed, as it is used when re-adding deleted members, and its impossible to do that in generation 1, but without it the DeletedMembers
property of the EmitBaseline doesn't represent the truth for generation 1, which was annoying for tests.
Ping @tmat for review |
1 similar comment
Ping @tmat for review |
Could you pls rebase, so that this PR only contains new changes? |
src/Compilers/Core/Portable/Emit/EditAndContinue/SymbolMatcher.cs
Outdated
Show resolved
Hide resolved
src/Compilers/Core/Portable/Emit/EditAndContinue/SymbolMatcher.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/EditAndContinueTests.cs
Outdated
Show resolved
Hide resolved
Sure thing, though unless you look commit-by-commit the diff should be right.. at least in GitHub it is, maybe CodeFlow gets confused? |
Yeah, might be CodeFlow. I see some changes that don't seem to belong. |
Rebased and force pushed. If github ends up hiding your comments, rest assured they're saved in my Outlook :D |
Reviewed up to commit 10. |
Added commit 11 to keep you on your toes! |
The commits will continue until morale improves (or @tmat reviews the PR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* upstream/main: (53 commits) Remove 'mangleName' parameter in PENamedTypeSymbolNonGeneric (dotnet#62813) Produce errors for 'partial file record' (dotnet#62686) [EnC] Allow renaming methods, properties, events etc. (dotnet#62364) Update AbstractFileHeaderDiagnosticAnalyzer.cs Rename file Make static Move tests Refactor Support ref field assignment in object initializers (dotnet#62584) Fix cref tags on generated VB's SyntaxFactory (dotnet#62578) Simplify Simplify Simplify Simplify Simplify Simplify Simplify Simplify Move helper methods Remove serialization ...
Part of #59264
Includes #62151 so just review
eba47b0
(#62364) or wait until that mergesAlso fixes #51011 because after this change, the incorrect edits were just silly.