Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify AbstractBuiltInCodeStyleDiagnosticAnalyzer constructors #62826

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Simplify AbstractBuiltInCodeStyleDiagnosticAnalyzer constructors #62826

merged 5 commits into from
Jul 22, 2022

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 21, 2022 •
edited
Loading

Replaces #62736

Addresses third point of #62666, and is follow-up to #62766 to remove unused language parameters

@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jul 21, 2022
@Youssef1313 Youssef1313 force-pushed the simplify-constructors branch 4 times, most recently from 796b9b6 to d06f54d Compare July 21, 2022 10:52
@Youssef1313 Youssef1313 changed the title Simplify AbstractBuiltInCodeStyleDiagnosticAnalyzer constructors Simplify AbstractBuiltInCodeStyleDiagnosticAnalyzer constructors Jul 21, 2022
@Youssef1313 Youssef1313 marked this pull request as ready for review July 21, 2022 11:00
@Youssef1313 Youssef1313 requested a review from a team as a code owner July 21, 2022 11:00
@Youssef1313 Youssef1313 mentioned this pull request Jul 21, 2022
Closed
@Youssef1313
Copy link
Member Author

@mavasani Can you take a look? Thanks!

@Youssef1313 Youssef1313 mentioned this pull request Jul 21, 2022
Closed
@runfoapp runfoapp bot mentioned this pull request Jul 21, 2022
Closed
@Youssef1313
Copy link
Member Author

@mavasani This is ready for review.

@mavasani mavasani merged commit 14f4520 into dotnet:main Jul 22, 2022
@ghost ghost added this to the Next milestone Jul 22, 2022
@Youssef1313 Youssef1313 deleted the simplify-constructors branch July 22, 2022 04:27
This was referenced Jul 26, 2022
Closed
Closed
@allisonchou allisonchou modified the milestones: Next, 17.4 P1 Jul 26, 2022
@Youssef1313 Youssef1313 mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavasani mavasani mavasani approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.4 P1
Development

Successfully merging this pull request may close these issues.
3 participants
@Youssef1313 @mavasani @allisonchou