Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SyntaxGenerator not working correctly with 'required' #62945

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Fix SyntaxGenerator not working correctly with 'required' #62945

merged 1 commit into from
Aug 8, 2022

Conversation

Youssef1313
Copy link
Member

Fixes #62371

@Youssef1313 Youssef1313 marked this pull request as ready for review July 26, 2022 17:36
@Youssef1313 Youssef1313 requested a review from a team as a code owner July 26, 2022 17:36
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jul 26, 2022
CyrusNajmabadi
CyrusNajmabadi approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Youssef1313
Copy link
Member Author

@CyrusNajmabadi @RikkiGibson Anything left to merge this? Thanks!

@RikkiGibson RikkiGibson self-assigned this Aug 8, 2022
@RikkiGibson RikkiGibson merged commit 2f62c90 into dotnet:main Aug 8, 2022
@RikkiGibson
Copy link
Contributor

Thanks @Youssef1313!

@ghost ghost added this to the Next milestone Aug 8, 2022
@Youssef1313 Youssef1313 deleted the fix-required-syntax-generator branch August 8, 2022 19:37
@allisonchou allisonchou mentioned this pull request Aug 16, 2022
Closed
@dibarbet dibarbet modified the milestones: Next, 17.4 P2 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

Assignees

@RikkiGibson RikkiGibson

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File and required modifiers are missing from CSharpAccessibilityFacts.GetAccessibilityAndModifiers
4 participants
@Youssef1313 @RikkiGibson @CyrusNajmabadi @dibarbet