Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IOperation test where IObjectCreationOperation.Constructor is null #63092

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Add IOperation test where IObjectCreationOperation.Constructor is null #63092

merged 2 commits into from
Oct 21, 2022

Conversation

Youssef1313
Copy link
Member

There was no IOperation tests covering this case for VB.

For C#, it doesn't look like constructor can be null, so I added an assert.

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 30, 2022 11:56
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jul 30, 2022
333fred
333fred approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 1). @dotnet/roslyn-compiler for a second review.

jcouv
jcouv approved these changes Oct 20, 2022
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 1)

@jcouv
Copy link
Member

jcouv commented Oct 20, 2022

/azp run

@jcouv jcouv self-assigned this Oct 20, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jcouv jcouv enabled auto-merge (squash) October 20, 2022 18:54
@build-analysis build-analysis bot mentioned this pull request Oct 20, 2022
Closed
2 tasks
AlekseyTs
AlekseyTs reviewed Oct 20, 2022
View reviewed changes
...ompilers/VisualBasic/Test/IOperation/IOperation/IOperationTests_IObjectCreationExpression.vb
M(New C.S())'BIND:"New C.S()"
End Sub
End Class]]>.Value
Dim expectedDiagnostics = <![CDATA[
Copy link
Contributor

@AlekseyTs AlekseyTs Oct 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dim expectedDiagnostics = <![CDATA[

Consider adding empty lines between multiline statements, this is going to improve readability. #Closed

auto-merge was automatically disabled October 21, 2022 05:43

Head branch was pushed to by a user without write access

AlekseyTs
AlekseyTs approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2)

@333fred 333fred merged commit 338932f into dotnet:main Oct 21, 2022
@ghost ghost added this to the Next milestone Oct 21, 2022
@333fred
Copy link
Member

333fred commented Oct 21, 2022

Thanks @Youssef1313!

@Youssef1313 Youssef1313 deleted the constructor-ioperation branch October 22, 2022 03:31
@allisonchou allisonchou mentioned this pull request Oct 24, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcouv jcouv jcouv approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.5 P1
Development

Successfully merging this pull request may close these issues.
5 participants
@Youssef1313 @jcouv @333fred @AlekseyTs @RikkiGibson