Give a specific error when a file type is duplicated in the same file #63829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cston
reviewed
Sep 7, 2022
| diagnostics.Add(ErrorCode.ERR_DuplicateNameInNS, declaration.Declarations[i].NameLocation, this.Name, this.ContainingSymbol); | ||
| // note: a declaration with the 'file' modifier will only be grouped with declarations in the same file. | ||
| diagnostics.Add((result & DeclarationModifiers.File) != 0 | ||
| ? ErrorCode.ERR_FileLocalDuplicateNameInNS |
There was a problem hiding this comment.
Are we testing this case? (It looks like the cases where we test the new error do not involve partial types.)
There was a problem hiding this comment.
Mostly there are existing tests for partial in the same file and different files. Duplication_06 changed, but mostly I think the baselines didn't change because the missing partial error takes priority over other duplication errors.
There was a problem hiding this comment.
Thanks. I asked because I was looking at commit 1 where Duplication_06 was still referencing the original ErrorCode.
cston
approved these changes
Sep 7, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62333