Add support to avoid showing F1 help for TS diagnostics #64242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#64145 TS diagnostics do not help corresponding help links, so the default help navigation invokes F1 help for the diagnostic ID. F1 help returns 404 error code for all TS diagnostics, so they wish to avoid showing F1 help. This PR adds a special well-known custom tag to allow diagnostics to skip F1 help navigation.
genlu
reviewed
Sep 23, 2022
src/Workspaces/Core/Portable/Diagnostics/WellKnownDiagnosticCustomTags.cs
Show resolved
Hide resolved
genlu
approved these changes
Sep 23, 2022
ghost
added this to the 
|
@mavasani thanks a lot! Once this gets inserted we will add the tag to our TypeScript diagnostics. |
MariaSolOs
reviewed
Sep 23, 2022
|
|
||
| namespace Microsoft.CodeAnalysis.ExternalAccess.VSTypeScript | ||
| { | ||
| internal static class VSTypeScriptWellKnownDiagnosticCustomTags |
There was a problem hiding this comment.
I never remember the rules correctly, but introducing this new class means that we (TypeScript VS) will also need to bump our Roslyn version to access this tag? @mavasani
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64145
TS diagnostics do not help corresponding help links, so the default help navigation invokes F1 help for the diagnostic ID. F1 help returns 404 error code for all TS diagnostics, so they wish to avoid showing F1 help. This PR adds a special well-known custom tag to allow diagnostics to skip F1 help navigation.