Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miscellaneous LSIF indexing issues to better match the 0.6.0 spec #64256

Conversation

jasonmalinowski
Copy link
Member

Fixes #63840, with each bullet point in its own commit.

@jasonmalinowski jasonmalinowski requested a review from a team as a code owner September 23, 2022 22:22
@jasonmalinowski jasonmalinowski self-assigned this Sep 23, 2022
Copy link
Member

@genlu genlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm probably not qualified to review this, but looks good to me FWIW

@jasonmalinowski jasonmalinowski merged commit 46b3ed9 into dotnet:main Sep 24, 2022
@jasonmalinowski jasonmalinowski deleted the fix-miscellaneous-lsif-indexing-issues branch September 24, 2022 01:05
@ghost ghost added this to the Next milestone Sep 24, 2022
@Cosifne Cosifne modified the milestones: Next, 17.4 P3 Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSIF generation can't be interpreted by 0.6.0 validators
3 participants