Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress IOperation validation for lambda parameter initializers #64630

Merged
merged 5 commits into from
Oct 26, 2022
Merged

Suppress IOperation validation for lambda parameter initializers #64630

merged 5 commits into from
Oct 26, 2022

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Oct 11, 2022 •
edited by jcouv
Loading

#27594 applies not only to local functions but also to lambdas.

Relates to test plan #62485

@jjonescz jjonescz marked this pull request as ready for review October 11, 2022 10:30
@jjonescz jjonescz requested a review from a team as a code owner October 11, 2022 10:30
333fred
333fred approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2), with small refactoring suggestion.

@jjonescz @333fred
Improve condition phrasing
47f2109 
Co-authored-by: Fred Silberberg <[email protected]>
@AlekseyTs
Copy link
Contributor

Expand IOperation check to lambdas

Consider using title that accurately describes the nature of the change. Were we not doing IOperation checks for lambdas before? Sounds unlikely. Also, it looks like the change actually suppresses some validation for lambdas.

@jjonescz jjonescz changed the title Expand IOperation check to lambdas Suppress IOperation validation for lambdas Oct 13, 2022
@jjonescz jjonescz mentioned this pull request Oct 13, 2022
Open
@AlekseyTs
Copy link
Contributor

@jjonescz

Suppress IOperation validation for lambdas

Is the change that broad?

@jjonescz jjonescz changed the title Suppress IOperation validation for lambdas Suppress IOperation validation for lambda parameter initializers Oct 13, 2022
@jjonescz
Copy link
Member Author

@AlekseyTs @333fred I pushed one more commit removing a prototype comment, PTAL

@jjonescz jjonescz merged commit 4cdce3f into dotnet:features/lambda-default-parameters Oct 26, 2022
@jjonescz jjonescz deleted the ldp-ioperation-2 branch October 26, 2022 07:24
@allisonchou allisonchou mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@cston cston cston approved these changes

@AlekseyTs AlekseyTs Awaiting requested review from AlekseyTs

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @AlekseyTs @333fred @cston