Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to main-vs-deps #64750

Merged
merged 11 commits into from
Oct 17, 2022
Merged

Conversation

dotnet-bot
Copy link
Collaborator

This is an automatically generated pull request from main into main-vs-deps.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-main-vs-deps
git reset --hard upstream/main-vs-deps
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-main-vs-deps --force

genlu and others added 11 commits October 12, 2022 11:04
Update VS Platform NuGet package version
RC2 builds of the .NET 7.0 SDK have generators that depend on 4.4
assemblies, so you'll get warnings without this.
…s and parameter default values. (#64634)

Part 1. 
Do not expose C# member semantic models directly to external consumers.
This could occur when member semantic models were used to support/represent speculative semantic models.
Now we expose ```SpeculativeSemanticModelWithMemberModel``` instead 

Part 2.
SpeculativeSemanticModelWithMemberModel - create child member models for attributes and parameter default values.

Fixes #60801.
Fixes #24135.
Upgrade our compiler to 4.4.0-2.final
Cache indices against our PEReference object, not the underlying metadata ID
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@dotnet-bot dotnet-bot merged commit fa92758 into main-vs-deps Oct 17, 2022
@ghost ghost added this to the Next milestone Oct 17, 2022
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants