Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow and emit params arrays in lambdas #64861

Merged
merged 16 commits into from
Oct 25, 2022
Merged

Allow and emit params arrays in lambdas #64861

merged 16 commits into from
Oct 25, 2022

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Oct 20, 2022 •
edited by jcouv
Loading

Adds basic support for params arrays in lambdas. Parsing support is already there, so this PR only removes an error around the params modifier and propagates the modifier into UnboundLambda, LambdaParameterSymbol, and the synthesized delegate type.

Error reporting around params and delegate conversions will be addressed in subsequent PRs.

Relates to test plan #62485

@jjonescz jjonescz marked this pull request as ready for review October 20, 2022 12:38
@jjonescz jjonescz requested a review from a team as a code owner October 20, 2022 12:38
@jjonescz jjonescz requested a review from cston October 21, 2022 12:22
333fred
333fred reviewed Oct 21, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done review pass (commit 12)

src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs Outdated Show resolved Hide resolved
src/Compilers/CSharp/Portable/Binder/Binder_Lambda.cs Show resolved Hide resolved
src/Compilers/CSharp/Portable/BoundTree/UnboundLambda.cs Show resolved Hide resolved
...p/Portable/Symbols/AnonymousTypes/SynthesizedSymbols/AnonymousType.DelegateTemplateSymbol.cs Outdated Show resolved Hide resolved
src/Compilers/CSharp/Portable/Symbols/Source/LambdaSymbol.cs Outdated Show resolved Hide resolved
@jjonescz jjonescz requested a review from 333fred October 24, 2022 07:23
@jjonescz jjonescz merged commit 3711c43 into dotnet:features/lambda-default-parameters Oct 25, 2022
@jjonescz jjonescz deleted the lambda-params-emit branch October 25, 2022 08:09
@allisonchou allisonchou mentioned this pull request Nov 23, 2022
Closed
@AlekseyTs AlekseyTs mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjonescz @333fred @cston