Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report structural lambda params errors #64960

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Report structural lambda params errors #64960

merged 7 commits into from
Nov 15, 2022

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Oct 25, 2022 •
edited by jcouv
Loading

This PR adds checking for params usage on lambdas.

Target type conversion errors are independent and hence in a separate PR: #64961

Relates to test plan #62485

@jjonescz jjonescz marked this pull request as ready for review October 25, 2022 11:18
@jjonescz jjonescz requested a review from a team as a code owner October 25, 2022 11:18
@jjonescz jjonescz mentioned this pull request Nov 3, 2022
Merged
@jjonescz
Copy link
Member Author

@dotnet/roslyn-compiler PTAL

333fred
333fred reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done review pass (commit 1)

src/Compilers/CSharp/Portable/Binder/Binder_Lambda.cs Outdated Show resolved Hide resolved
src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs Outdated Show resolved Hide resolved
src/Compilers/CSharp/Portable/Symbols/Source/ParameterHelpers.cs Outdated Show resolved Hide resolved
src/Compilers/CSharp/Test/Semantic/Semantics/LambdaTests.cs Show resolved Hide resolved
src/Compilers/CSharp/Test/Semantic/Semantics/NullableReferenceTypesTests.cs Outdated Show resolved Hide resolved
333fred
333fred approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 7)

@jjonescz
Copy link
Member Author

@dotnet/roslyn-compiler for the second review

@jjonescz jjonescz merged commit 6a5887b into dotnet:features/lambda-default-parameters Nov 15, 2022
@jjonescz jjonescz deleted the lambda-params-structural-errors branch November 15, 2022 08:34
@allisonchou allisonchou mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredpar jaredpar jaredpar left review comments

@333fred 333fred 333fred approved these changes

@cston cston cston approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @jaredpar @333fred @cston