Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Make type partial" codefix #65018

Merged
merged 23 commits into from
Dec 4, 2022
Merged

Add "Make type partial" codefix #65018

merged 23 commits into from
Dec 4, 2022

Conversation

DoctorKrolic
Copy link
Contributor

@DoctorKrolic DoctorKrolic commented Oct 26, 2022 •
edited
Loading

Closes: #61611

Was doing some MAUI stuff the other day and it was really annoying that every time I add an [ObservableProperty] to a newly created view model, I have to manually add partial to class declaration without ability of 3-clicks fast fix. So here we go, my first fully implemented codefix 🙂

@DoctorKrolic DoctorKrolic requested a review from a team as a code owner October 26, 2022 18:55
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Oct 26, 2022
CyrusNajmabadi
CyrusNajmabadi approved these changes Nov 2, 2022
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with test.

CyrusNajmabadi
CyrusNajmabadi approved these changes Dec 3, 2022
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, witht he minor changes mentinoed in the review. can merge in after that :) thanks!

@DoctorKrolic DoctorKrolic changed the title Add "Make declaration partial" codefix Add "Make type partial" codefix Dec 4, 2022
@DoctorKrolic
Copy link
Contributor Author

@CyrusNajmabadi I've chosen the Make type partial title, so other feedback is no longer relevant. I guess, this is the final change)

CyrusNajmabadi
CyrusNajmabadi approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@CyrusNajmabadi CyrusNajmabadi enabled auto-merge (squash) December 4, 2022 17:39
@CyrusNajmabadi CyrusNajmabadi merged commit c01cce6 into dotnet:main Dec 4, 2022
@ghost ghost added this to the Next milestone Dec 4, 2022
@DoctorKrolic DoctorKrolic deleted the make-declaration-partial-codefix branch December 4, 2022 19:03
@Eli-Black-Work Eli-Black-Work mentioned this pull request Dec 5, 2022
Open
@allisonchou allisonchou mentioned this pull request Dec 15, 2022
Closed
@Cosifne Cosifne modified the milestones: Next, 17.5 P3 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.5 P3
Development

Successfully merging this pull request may close these issues.

Add a code fix to suggest adding partial modifier
4 participants
@DoctorKrolic @CyrusNajmabadi @Youssef1313 @Cosifne