Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit ParamArrayAttribute for synthesized delegates #65533

Merged
merged 15 commits into from
Nov 29, 2022
Merged

Emit ParamArrayAttribute for synthesized delegates #65533

merged 15 commits into from
Nov 29, 2022

Conversation

jjonescz
Copy link
Member

Relates to test plan #62485.

@jjonescz jjonescz marked this pull request as ready for review November 21, 2022 13:51
@jjonescz jjonescz requested a review from a team as a code owner November 21, 2022 13:51
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

@AlekseyTs

This comment was marked as resolved.

Sign in to view
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 3)

jjonescz added a commit to jjonescz/roslyn that referenced this pull request Nov 23, 2022
@jjonescz
Remove test added in dotnet#65533 to avoid conflicts
e9b9df1
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 11)

AlekseyTs
AlekseyTs approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 15)

@jjonescz jjonescz merged commit f431606 into dotnet:main Nov 29, 2022
@jjonescz jjonescz deleted the lambda-params-emit-attr branch November 29, 2022 10:08
@ghost ghost added this to the Next milestone Nov 29, 2022
jjonescz added a commit that referenced this pull request Nov 29, 2022
@jjonescz
Add lambda defaults/params tests from the test plan review (#65458)
44186be 
* Add tests from the test plan review

* Add tests for `default`

* Add NoPIA tests

* Remove duplicate test

* Remove test added in #65533 to avoid conflicts
@allisonchou allisonchou modified the milestones: Next, 17.5 P2 Nov 30, 2022
@allisonchou allisonchou mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees
No one assigned
Labels
Area-Compilers
Projects
None yet
Milestone
17.5 P2
Development

Successfully merging this pull request may close these issues.
4 participants
@jjonescz @AlekseyTs @333fred @allisonchou