Consider delegate default parameter values and params in symbol matcher
#65579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
@tmat or @davidwengier, can either of you two look at this as well?
AlekseyTs
reviewed
Nov 30, 2022
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/SymbolMatcherTests.cs
Show resolved
Hide resolved
AlekseyTs
reviewed
Nov 30, 2022
src/Compilers/CSharp/Test/Emit/Emit/EditAndContinue/SymbolMatcherTests.cs
Show resolved
Hide resolved
|
Done with review pass (commit 1) |
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stumbled upon this while working on synthesized delegate templates. I also tried to add an EditAndContinue test but it does not seem possible as changing default parameter value or
paramsmodifier changes the synthesized delegate type which seems unsupported by EnC.Relates to test plan #62485.