Bump mac editor and implement CocoaTextBufferVisibilityTracker #65643
Conversation
This should help reduce the number classification marks triggering in the editor in VSMac. Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1654358 Backport of #65568 without the refactoring.
|
Were you guys able to try this out? in particular, it would be really valuable to ensure that the visbiility checks are actually working in vs4mac at runtime. and that you see that the non-visible tabs now get throttled to one update every 3 seconds per tagger. |
|
This version of the change (on top of main, in the older PR) is what Marius was testing locally with good results. I'll be testing a build from this branch today. |
| namespace Microsoft.CodeAnalysis.Workspaces | ||
| { | ||
| [Export(typeof(ITextBufferVisibilityTracker))] | ||
| internal sealed class CocoaTextBufferVisibilityTracker : ITextBufferVisibilityTracker |
There was a problem hiding this comment.
i haven't looked closely. but the presumption is that this is a straight port, just tweaked fort he cocoa visibility checks. if so, this is ok with me. if anything else was changed, lmk. thanks!
There was a problem hiding this comment.
Yup, that is the intent! Thank you!
There was a problem hiding this comment.
Yeah, it's just the commit I initially made I think. And that was the changeset, I think the diff itself is just removing .VisualElement and changing the event handler type.
|
LGTM then given the manual validation as well :) |
My speedscope trace with the insertion PR doesn't contain the problematic frames, so I assume that's fine! |
|
@arkalyanms since this is targetting 17.4 |
|
Thanks, I'll follow up with @sandyarmstrong on https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1689011 to make the 17.4 servicing happen. |
sandyarmstrong
changed the base branch from
release/dev17.4
to
release/vsmac17.4
davidwengier
deleted the
dev/therzok/cocoa-text-buffer-visibility-tracker-17.4
branch
davidwengier
restored the
dev/therzok/cocoa-text-buffer-visibility-tracker-17.4
branch
JoeRobich
deleted the
dev/therzok/cocoa-text-buffer-visibility-tracker-17.4
branch
This should help reduce the number classification marks triggering in the editor in VSMac.
Fixes https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1689011
Backport of #65568 without the refactoring.