Move IDS_FeatureRefLocalsReturns out of the parser #65710
Conversation
fix fix fix fix fix fix
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberFieldSymbol.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberFieldSymbol.cs
Outdated
Show resolved
Hide resolved
src/Compilers/CSharp/Portable/Symbols/Source/SourceMemberFieldSymbol.cs
Outdated
Show resolved
Hide resolved
| _refKind = RefKind.None; | ||
| } | ||
|
|
||
| syntax.ReturnType.SkipRef(_declarationDiagnostics, out _refKind); |
There was a problem hiding this comment.
would _refKind = syntax.ReturnType.GetRefKind(DiagnosticBag) be more appropriate here?
There was a problem hiding this comment.
woudln't that avoid the error about using a ref-return on a local function?
| @@ -761,7 +761,7 @@ private string GetDebuggerDisplay() | |||
| bool isVar; | |||
| bool isConst = false; | |||
| AliasSymbol alias; | |||
| var declType = BindVariableTypeWithAnnotations(component.Designation, diagnostics, component.Type.SkipScoped(out _).SkipRef(out _), ref isConst, out isVar, out alias); | |||
| var declType = BindVariableTypeWithAnnotations(component.Designation, diagnostics, component.Type.SkipScoped(out _).SkipRef(), ref isConst, out isVar, out alias); | |||
There was a problem hiding this comment.
It seemed like in some places, we are skipping ref, but some other check is deciding conditionally whether ref is OK in that position. For example, in BindVariableTypeWithAnnotations. It looks like some of the time you deliberately called the overload to pass diagnostics: null, like in SourceLocalSymbol.
It looks like the SkipRef overload that takes a diagnostic bag is specifically checking for the ref locals and returns feature. I am wondering if the name of this method should be changed, e.g. SkipRef() with no parameters sticks around, and SkipRef(DiagnosticBag, out RefKind gets renamed to something like SkipRefInLocalOrReturn(DiagnosticBag, out RefKind). Then it might be slightly easier to tell at a glance why it's expected to pass a diagnostic bag or not.
Co-authored-by: Rikki Gibson <[email protected]>
|
@RikkiGibson thanks. this got a lot nicer! |
ghost
added this to the 
This is the final parser change that i'm aware of where we produce different trees based on language version. W00t!