Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create DkmCustomUIVisualizerInfo instances with ExtensionPartId field #65730

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Create DkmCustomUIVisualizerInfo instances with ExtensionPartId field #65730

merged 2 commits into from
Dec 7, 2022

Conversation

mpeyrotc
Copy link
Contributor

@mpeyrotc mpeyrotc commented Dec 2, 2022

Debugger Managed Custom Visualizers can now be installed via .VSIX packages into Visual Studio. However, we need a new mechanism to identify them within the new extension manager that processes them. Therefore, visualizers now have a new GUID field for that purpose.

Since the Debugger Component that instantiates visualizers receives its information from the DkmSuccessEvaluationResult that the Result Provider from Roslyn provides, we need it to also create the DkmCustomUIVisualizerInfo collection that is passes to the DkmSuccessEvaluationResult with the new field.

Hence, this change makes sure to create new DkmCustomUIVisualizerInfo instances with the new ExtensionPartId field.

@mpeyrotc mpeyrotc requested a review from a team as a code owner December 2, 2022 20:24
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Dec 2, 2022
@dnfadmin
Copy link

dnfadmin commented Dec 2, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.

@mpeyrotc
Copy link
Contributor Author

mpeyrotc commented Dec 2, 2022

@gregg-miskelly @dustincoleman FYI.

gregg-miskelly
gregg-miskelly reviewed Dec 2, 2022
View reviewed changes
eng/Versions.props Outdated Show resolved Hide resolved
@gregg-miskelly
Copy link

CC @tmat

tmat
tmat approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@tmat tmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mpeyrotc
Copy link
Contributor Author

mpeyrotc commented Dec 5, 2022

@tmat, what is your policy regarding changes in the debug engine reaching VS? The change has made it into the release branch for 17.5 and is also in main. Is there anything else I should wait on before it can be completed?

@mpeyrotc
Copy link
Contributor Author

mpeyrotc commented Dec 7, 2022

@sharwell could I bother you with a review?

@tmat
Copy link
Member

tmat commented Dec 7, 2022

Merging, it's good to go.

@tmat tmat merged commit 8878c0e into dotnet:main Dec 7, 2022
@ghost ghost added this to the Next milestone Dec 7, 2022
@mpeyrotc mpeyrotc deleted the dev/mapeyrot/process_new_eval_attr_field branch December 8, 2022 23:00
@allisonchou allisonchou mentioned this pull request Dec 15, 2022
Closed
@Cosifne Cosifne modified the milestones: Next, 17.5 P3 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregg-miskelly gregg-miskelly gregg-miskelly left review comments

@tmat tmat tmat approved these changes

Assignees
No one assigned
Labels
Area-Interactive Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.5 P3
Development

Successfully merging this pull request may close these issues.
5 participants
@mpeyrotc @dnfadmin @gregg-miskelly @tmat @Cosifne