-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Results of running new "use nameof for nullable attributes" analyzer/fixer on roslyn #65733
Conversation
@dotnet/roslyn-compiler @dotnet/roslyn-ide ptal. |
@@ -1126,7 +1126,7 @@ private BoundLambda ReallyBindForErrorRecovery() | |||
?? rebind(ReallyInferReturnType(delegateType: null, ImmutableArray<TypeWithAnnotations>.Empty, ImmutableArray<RefKind>.Empty)); | |||
|
|||
// Rebind a lambda to push target conversions through the return/result expressions | |||
[return: NotNullIfNotNull("lambda")] BoundLambda? rebind(BoundLambda? lambda) | |||
[return: NotNullIfNotNull(nameof(lambda))] BoundLambda? rebind(BoundLambda? lambda) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ What's the scope here if a local variable has the same name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's only the parameters that are in scope.
No description provided.