Move classification tests to new framework #65734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
approved these changes
Dec 2, 2022
dibarbet
commented
Dec 2, 2022
| { | ||
| await JoinableTaskFactory.SwitchToMainThreadAsync(cancellationToken); | ||
| var dte = await GetRequiredGlobalServiceAsync<SDTE, EnvDTE.DTE>(cancellationToken); | ||
| dte.ExecuteCommand(commandName, argument); |
There was a problem hiding this comment.
@sharwell wanted to check with you if this was appropriate - this is how the old framework did it, but the new framework uses a different method - https://github.com/microsoft/vs-extension-testing/blob/d460a813832a479f21ec0d076de213e6a1a5ccae/src/Microsoft.VisualStudio.Extensibility.Testing.SourceGenerator.UnitTests/Resources/TestGenerationForVS2022/ShellInProcess1.g.cs#L61
However I didn't see (or understand perhaps) a way to pass args in the way that the new framework is doing it.
There was a problem hiding this comment.
The new approach intentionally avoids DTE. We can update it to support arguments tomorrow. 👍
dibarbet
force-pushed
the
move_classification_tests
branch
from
ed4123e
to
c5bb21b
Compare
This reverts commit a07c343.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.