Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix correctness build #65789

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Dec 5, 2022

#65729 (added a new analyzer) and #62242 (added new rule violated by analyzer) merged independently without CI re-triggering.

The temporary fix here is to add the new rule to the allow list until documentation can be added (cc @CyrusNajmabadi for tracking that).

@dibarbet dibarbet requested a review from a team December 5, 2022 22:25
@dibarbet dibarbet marked this pull request as ready for review December 5, 2022 22:25
@dibarbet dibarbet requested a review from a team as a code owner December 5, 2022 22:25
@jasonmalinowski jasonmalinowski merged commit 1c0f249 into dotnet:main Dec 5, 2022
@ghost ghost added this to the Next milestone Dec 5, 2022
@jasonmalinowski
Copy link
Member

Force merging since the validation leg that was broken is now fixed, and we don't imagine a way editing a markdown file can break anything else.

@dibarbet dibarbet deleted the fix_correctness branch December 5, 2022 23:12
@mavasani
Copy link
Contributor

mavasani commented Dec 6, 2022

Ah, my bad. Sorry about the break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants