Fix Regex features in raw-string-literals. #65838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Dec 7, 2022
| void Goo() | ||
| { | ||
| var r = new Regex(""" | ||
| $$ (a)\0\1 |
There was a problem hiding this comment.
this previously would crash in highlight refs.
CyrusNajmabadi
commented
Dec 7, 2022
| { | ||
| void goo() | ||
| { | ||
| var r = new Regex("""$$ """); |
There was a problem hiding this comment.
this case would previously assert, but not crash.
CyrusNajmabadi
commented
Dec 7, 2022
| // that is relevant is the \ character, and it's only relevant if we insert into | ||
| // a normal string and not a verbatim string. There are no other regex characters | ||
| // that completion will produce that need any escaping. | ||
| Debug.Assert(token.Kind() == SyntaxKind.StringLiteralToken); |
CyrusNajmabadi
commented
Dec 7, 2022
| // Characters can be discontiguous (for example, in multi-line-raw-string literals). So if the | ||
| // position is in one of the gaps, it won't be able to find a corresponding virtual char. | ||
| if (index < 0) | ||
| return null; |
akhera99
approved these changes
Dec 7, 2022
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65836