Remove mutable state from rename #65848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Dec 7, 2022
| @@ -118,6 +114,8 @@ public async Task<MutableConflictResolution> ResolveConflictsAsync() | |||
| var intermediateSolution = conflictResolution.OldSolution; | |||
| foreach (var documentsByProject in documentsGroupedByTopologicallySortedProjectId) | |||
| { | |||
| var conflictLocations = SpecializedCollections.EmptySet<ConflictLocationInfo>(); | |||
There was a problem hiding this comment.
conflict locations is fresh for each project we look at. we know that because in phase-0, we always assign over whatever the prior project computed. so this just makes things simpler here.
akhera99
approved these changes
Dec 9, 2022
ghost
added this to the 
| { | ||
| try | ||
| { | ||
| var documentIds = new HashSet<DocumentId>(); |
There was a problem hiding this comment.
Is it faster to use an ImmutableHashSet builder here?
| { | ||
| try | ||
| { | ||
| var documentIds = new HashSet<DocumentId>(); | ||
| var possibleNameConflictsList = new List<string>(); |
There was a problem hiding this comment.
Ditto: immutable array builder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was finding these mutable fields very confusing for determining what was going on in rename as i work on shared syntax trees. So pulled out this PR to clean it up.