Simplify lsif generation concepts #65858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Dec 8, 2022
| @@ -113,10 +113,12 @@ public static async Task<CompilerInvocation> CreateFromInvocationInfoAsync(Compi | |||
| hostObjectType: null); | |||
|
|
|||
| var solution = workspace.CurrentSolution.AddProject(projectInfo); | |||
| var compilation = await solution.GetRequiredProject(projectId).GetRequiredCompilationAsync(CancellationToken.None); | |||
| var options = GeneratorOptions.Default; | |||
There was a problem hiding this comment.
note that we always used GeneratorOptions.Default here. so the callers of this method just pas that along instead.
|
@jasonmalinowski ptal. |
CyrusNajmabadi
commented
Dec 8, 2022
src/Features/LanguageServer/Protocol/Handler/Hover/HoverHandler.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jason Malinowski <[email protected]>
jasonmalinowski
approved these changes
Dec 10, 2022
| @@ -18,29 +18,16 @@ | |||
|
|
|||
| namespace Microsoft.CodeAnalysis.LanguageServerIndexFormat.Generator | |||
| { | |||
| internal class CompilerInvocation | |||
| internal static class CompilerInvocation | |||
There was a problem hiding this comment.
Not sure if this can/should be renamed to something else but it's fine.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be reviewed one PR at a time.