Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move BasicBuild to new integration test framework and implement #65889

Merged
merged 3 commits into from
Dec 13, 2022

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Dec 8, 2022

The csharp version is already moved. I noticed this one wasn't and didn't actually test anything, so I implemented it to have the same behavior as the csharp version.

}

[IdeFact, Trait(Traits.Feature, Traits.Features.Build)]
public async Task BuildProject()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented the same as the C# version


VisualStudio.Editor.SetText(editorText);

// TODO: Validate build works as expected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wat.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was a great test 😆

@dibarbet dibarbet merged commit 11f00a7 into dotnet:main Dec 13, 2022
@dibarbet dibarbet deleted the move_basic_build branch December 13, 2022 19:19
@ghost ghost added this to the Next milestone Dec 13, 2022
@Cosifne Cosifne modified the milestones: Next, 17.5 P3 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants