Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XAML LSP by using a queue provider instead of subclassing #65898

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix XAML LSP by using a queue provider instead of subclassing #65898

merged 1 commit into from
Dec 9, 2022

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Dec 9, 2022 •
edited
Loading

Resolves #65888

image

@dibarbet dibarbet added Area-IDE LSP issues related to the roslyn language server protocol implementation labels Dec 9, 2022
@dibarbet dibarbet requested a review from a team as a code owner December 9, 2022 01:16
@dibarbet dibarbet merged commit 1100e56 into dotnet:main Dec 9, 2022
@ghost ghost added this to the Next milestone Dec 9, 2022
@dibarbet dibarbet deleted the fix_xaml_lsp branch December 9, 2022 03:17
@allisonchou allisonchou mentioned this pull request Dec 15, 2022
Closed
@Cosifne Cosifne modified the milestones: Next, 17.5 P3 Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
17.5 P3
Development

Successfully merging this pull request may close these issues.

PR 64583 broke LSP-based XAML intellisense
3 participants
@dibarbet @CyrusNajmabadi @Cosifne