Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed CA1854: Prefer IDictionary.TryGetValue(TKey, out TValue) occurrences #66515

Merged
merged 10 commits into from
Jun 27, 2023
Merged

Fixed CA1854: Prefer IDictionary.TryGetValue(TKey, out TValue) occurrences #66515

merged 10 commits into from
Jun 27, 2023

Conversation

Miizukii
Copy link
Contributor

@Miizukii Miizukii requested review from a team as code owners January 22, 2023 10:34
@ghost ghost added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Jan 22, 2023
@Miizukii Miizukii requested a review from 333fred January 28, 2023 20:37
333fred
333fred approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dotnet/roslyn-compiler for a second review.

@AlekseyTs
Copy link
Contributor

@Miizukii Is it reasonable to expect that everyone knows what CA1854 is about?

@Miizukii
Copy link
Contributor Author

Miizukii commented Feb 7, 2023

not sure, would Fixed CA1854: Prefer the IDictionary.TryGetValue(TKey, out TValue) occurrences be better?

@AlekseyTs
Copy link
Contributor

would Fixed CA1854: Prefer the IDictionary.TryGetValue(TKey, out TValue) occurrences be better?

Much better, I think.

@jcouv
Copy link
Member

jcouv commented Feb 7, 2023

@dotnet/roslyn-ide for review of IDE portions. Thanks

@Miizukii Miizukii changed the title Fixed CA1854 occurrences Fixed CA1854: Prefer IDictionary.TryGetValue(TKey, out TValue) occurrences Feb 7, 2023
@Miizukii
Copy link
Contributor Author

Miizukii commented Feb 9, 2023

Addressed all feedback, failure looks unrelated to my change

CyrusNajmabadi
CyrusNajmabadi approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with teh requested IDE changes.

Miizukii and others added 4 commits February 9, 2023 21:57
@Miizukii @CyrusNajmabadi
Apply suggestions from code review
dfb9ca6 
Co-authored-by: CyrusNajmabadi <[email protected]>
@Miizukii
Merge branch 'dotnet:main' into FixedCa1854
18617c8
@Miizukii
Merge remote-tracking branch 'origin/main' into FixedCa1854
bd4ba06 
# Conflicts:
#	src/Features/Core/Portable/SyncNamespaces/AbstractSyncNamespacesService.cs
#	src/Features/LanguageServer/Protocol/Workspaces/LspWorkspaceManager.cs
@Miizukii
Merge branch 'main' into FixedCa1854
1956206
@333fred
Copy link
Member

333fred commented Jun 26, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@333fred
Copy link
Member

333fred commented Jun 26, 2023

Rerunning CI since it's been a while, then we'll get this merged. Sorry for the delay @Miizukii.

@333fred 333fred enabled auto-merge (squash) June 26, 2023 18:52
@333fred 333fred disabled auto-merge June 27, 2023 00:45
@333fred 333fred enabled auto-merge (squash) June 27, 2023 00:45
@333fred 333fred merged commit ab87b4f into dotnet:main Jun 27, 2023
@ghost ghost added this to the Next milestone Jun 27, 2023
@Miizukii Miizukii deleted the FixedCa1854 branch June 27, 2023 16:36
@RikkiGibson RikkiGibson modified the milestones: Next, 17.7 P3 Jun 28, 2023
@allisonchou allisonchou mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@333fred 333fred 333fred approved these changes

@jjonescz jjonescz jjonescz approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-Compilers Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.7 P3
Development

Successfully merging this pull request may close these issues.
8 participants
@Miizukii @AlekseyTs @jcouv @333fred @jjonescz @CyrusNajmabadi @Youssef1313 @RikkiGibson