Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite binary logs #66559

Merged
merged 8 commits into from
Jan 26, 2023
Merged

Don't overwrite binary logs #66559

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
07f21b7
Don't overwrite binary logs
jaredpar Jan 26, 2023
43b4571
enable trace for diff issue
jaredpar Jan 26, 2023
9a6689e
Work around NuGet static graph restore bug
jaredpar Jan 26, 2023
59a537a
limit to CI only
jaredpar Jan 26, 2023
0fe1e9f
copy / paste bug
jaredpar Jan 26, 2023
8966289
it's your fault for letting me code
jaredpar Jan 26, 2023
b6887e9
why why why
jaredpar Jan 26, 2023
7991567
yml owns me
jaredpar Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ function Process-Arguments() {
}

if ($binaryLog -and ($binaryLogName -eq "")) {
$binaryLogName = "Build.binlog"
$script:binaryLogName = "Build.binlog"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm scared.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well because you asked ...

It's because when powershell reads a variable it will check function scope, then script scope. But if you write a variable it will write it in the function scope, even if one exists at script scope. So you need to be very explicit that you're writing a script scoped variable here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the $binaryLogName just above be $script:binaryLogName as well then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the one on line 228?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uses on 182 are reads. Those will fall back to script scope. Line 228 is creating a new variable $binaryLogPath which is intentionally function level scope.

Why don't we always use script: when accessing script variables and instead rely on fallback rules? I don't have a good argument for that other than that's just kinda how it's written in a lot of cases. It's like asking why we require this. for extension methods but not for normal instance methods.

}

$anyUnit = $testDesktop -or $testCoreClr
Expand Down