Add FAR support for finding 'Add' methods used in collection initializers. #66700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dibarbet
approved these changes
Feb 3, 2023
| @@ -121,7 +134,12 @@ private static bool IsGetAwaiterMethod(IMethodSymbol methodSymbol) | |||
|
|
|||
| var suppressionReferences = await FindReferencesInDocumentInsideGlobalSuppressionsAsync( | |||
| symbol, state, cancellationToken).ConfigureAwait(false); | |||
| return nameMatches.Concat(forEachMatches, deconstructMatches, getAwaiterMatches, suppressionReferences); | |||
|
|
|||
| var addMatches = IsAddMethod(symbol) | |||
There was a problem hiding this comment.
not entirely related to this PR, but do we already support object initializers?
There was a problem hiding this comment.
Yes we do. Those are normal identifier references, so they fall out of normal searches. collection-initializers are an interesting duck where the 'Add' methods are implicitly referenced and need to be specially found.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22449