Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record added node output states as new #66725

Merged
merged 7 commits into from
May 12, 2023
Merged

Record added node output states as new #66725

merged 7 commits into from
May 12, 2023

Commits on Feb 6, 2023

  1. Record added node output states as new 

    The `(EntryState.Modified, EntryState.Added) => IncrementalStepRunReason.Modified` state mapping was recently added in dotnet#61308, but doesn't look correct to me. Since this value is used as the output status, and the outputs are new, I believe the correct state should be `IncrementalStepRunReason.New` instead.
    @sbergen
    sbergen committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    dc10905 View commit details
    Browse the repository at this point in the history

  2. Update tests that were added since I originally implemented the change

    @sbergen
    sbergen committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    16a2862 View commit details
    Browse the repository at this point in the history

  3. Update documentation for IncrementalStepRunReason

    @sbergen
    sbergen committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    ce1ab42 View commit details
    Browse the repository at this point in the history

  4. Update VB tests also

    @sbergen
    sbergen committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    63b5ed4 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2023

  1. Merge remote-tracking branch 'upstream/main' into reapply-fix-run-ste… 

    …p-added-output
    @sbergen
    sbergen committed May 10, 2023
    Configuration menu
    Copy the full SHA
    c681f6d View commit details
    Browse the repository at this point in the history

  2. Add note about breaking changes with IncrementalStepRunReason

    @sbergen
    sbergen committed May 10, 2023
    Configuration menu
    Copy the full SHA
    65e2a3c View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Merge branch 'main' into sbergen/reapply-fix-run-step-added-output

    @jjonescz
    jjonescz committed May 12, 2023
    Configuration menu
    Copy the full SHA
    f215f3c View commit details
    Browse the repository at this point in the history