Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interceptors: handle duplicates, additional signature validation, etc. #67786

Merged
merged 34 commits into from
Apr 25, 2023
Merged

Interceptors: handle duplicates, additional signature validation, etc. #67786

merged 34 commits into from
Apr 25, 2023

Commits on Apr 13, 2023

  1. Detect duplicate interceptions

    @RikkiGibson
    RikkiGibson committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    5c4e289 View commit details
    Browse the repository at this point in the history

  2. fix formatting

    @RikkiGibson
    RikkiGibson committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    b769c0e View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2023

  1. Fix dictionary usage. Test some file local attribute cases. Check sco… 

    …ped modifiers.
    @RikkiGibson
    RikkiGibson committed Apr 15, 2023
    Configuration menu
    Copy the full SHA
    a1f0eab View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Fix nullable warning

    @RikkiGibson
    RikkiGibson committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    042d1d6 View commit details
    Browse the repository at this point in the history

  2. Test 'params'. Test 'object.ReferenceEquals'. Handle more prototype c… 

    …omments.
    @RikkiGibson
    RikkiGibson committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    565c39a View commit details
    Browse the repository at this point in the history

  3. fix position diagnostics

    @RikkiGibson
    RikkiGibson committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    f09ecb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. fix lsp test

    @RikkiGibson
    RikkiGibson committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    5edf9cf View commit details
    Browse the repository at this point in the history

  2. Don't propagate InvokedAsExtensionMethod past lowering

    @RikkiGibson
    RikkiGibson committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    b5fb444 View commit details
    Browse the repository at this point in the history

  3. Test file path case difference

    @RikkiGibson
    RikkiGibson committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    732dd91 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Permit safe nullable differences

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    e47ce9d View commit details
    Browse the repository at this point in the history

  2. Fix DiagnosticTest

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    678c4aa View commit details
    Browse the repository at this point in the history

  3. Update spec

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    330ae61 View commit details
    Browse the repository at this point in the history

  4. fix example type

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    aec866a View commit details
    Browse the repository at this point in the history

  5. Use explicit 'bool' type

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    4b7fa44 View commit details
    Browse the repository at this point in the history

  6. remove TODO

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    3534505 View commit details
    Browse the repository at this point in the history

  7. Fix crash when ROSLYN_TEST_USEDASSEMBLIES is defined

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    d2053de View commit details
    Browse the repository at this point in the history

  8. Fix nullable warning

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    d47412a View commit details
    Browse the repository at this point in the history

  9. Fix formatting

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    ca4cea8 View commit details
    Browse the repository at this point in the history

  10. More tests

    @RikkiGibson
    RikkiGibson committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    21c1d56 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Add more tests

    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    805fc9a View commit details
    Browse the repository at this point in the history

  2. Update baselines. Prefer reporting mismatch issues on attribute inste… 

    …ad of method.
    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    87bcad6 View commit details
    Browse the repository at this point in the history

  3. Handle concurrent attribute decoding

    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3da2bad View commit details
    Browse the repository at this point in the history

  4. add PROTOTYPE

    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f4f05aa View commit details
    Browse the repository at this point in the history

  5. permit safe scoped variance

    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    202914a View commit details
    Browse the repository at this point in the history

  6. Execute more test. Test intercepting ReferenceEquals.

    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    c677ca7 View commit details
    Browse the repository at this point in the history

  7. Adjust comment

    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3a95687 View commit details
    Browse the repository at this point in the history

  8. adjust comment

    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    2bfe8e2 View commit details
    Browse the repository at this point in the history

  9. skip verification in InterceptorExtern

    @RikkiGibson
    RikkiGibson committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    03be70a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. add another duplicate test

    @RikkiGibson
    RikkiGibson committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    5c97905 View commit details
    Browse the repository at this point in the history

  2. Clarify comment

    @RikkiGibson
    RikkiGibson committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    b6eb568 View commit details
    Browse the repository at this point in the history

  3. Add use site info

    @RikkiGibson
    RikkiGibson committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    76d66d9 View commit details
    Browse the repository at this point in the history

  4. fix double negative

    @RikkiGibson
    RikkiGibson committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    f3c877e View commit details
    Browse the repository at this point in the history

  5. test interceptable call with method type arguments in signature

    @RikkiGibson
    RikkiGibson committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    43205e8 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. add PROTOTYPE based on offline discussion

    @RikkiGibson
    RikkiGibson committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    8664dad View commit details
    Browse the repository at this point in the history