Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EnC service a MEF service instead of a workspace service #67896

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Make EnC service a MEF service instead of a workspace service #67896

merged 1 commit into from
Apr 25, 2023

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 20, 2023 •
edited
Loading

Keeps workspace service around to be able to access the MEF service from a workspace context.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 20, 2023
@tmat
Copy link
Member Author

tmat commented Apr 24, 2023 •
edited
Loading

@davidwengier PTAL

@tmat tmat marked this pull request as ready for review April 24, 2023 19:51
@tmat tmat requested a review from a team as a code owner April 24, 2023 19:51
@tmat tmat merged commit 8dc7ca5 into dotnet:main Apr 25, 2023
@tmat tmat deleted the EncMefService branch April 25, 2023 23:12
@ghost ghost added this to the Next milestone Apr 25, 2023
@allisonchou allisonchou mentioned this pull request May 2, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwengier davidwengier davidwengier approved these changes

Assignees
No one assigned
Labels
Area-Interactive untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
17.7 P2
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @davidwengier @Cosifne