Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard code segment constants for common type sizes #67921

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Hard code segment constants for common type sizes #67921

merged 3 commits into from
Apr 25, 2023

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Apr 21, 2023 •
edited
Loading

  • Fix calculation of array sizes
  • Allow for inlining for common sizes on .NET Framework
  • Reduces inline code size on .NET prior to version 8 (where lzcnt constant folding is first implemented)

Follow-up to #67558

@sharwell sharwell requested a review from a team as a code owner April 21, 2023 21:55
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 21, 2023
@sharwell
Hard code segment constants for common type sizes
807b383 
* Fix calculation of array sizes
* Allow for inlining for common sizes on .NET Framework
* Reduces inline code size on .NET prior to version 8 (where lzcnt constant folding is first implemented)
@AlekseyTs
Copy link
Contributor

Done with review pass (commit 1)

AlekseyTs
AlekseyTs approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 3)

@jcouv jcouv self-assigned this Apr 25, 2023
jcouv
jcouv approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 3)

@jcouv jcouv added this to the 17.7 milestone Apr 25, 2023
@jcouv jcouv removed the untriaged Issues and PRs which have not yet been triaged by a lead label Apr 25, 2023
@jcouv jcouv merged commit 79d31c3 into dotnet:main Apr 25, 2023
@ghost ghost modified the milestones: 17.7, Next Apr 25, 2023
@sharwell sharwell deleted the inline-access branch April 25, 2023 16:24
@dibarbet dibarbet modified the milestones: Next, 17.7 P1 Apr 25, 2023
@genlu genlu mentioned this pull request Apr 26, 2023
Closed
@allisonchou allisonchou mentioned this pull request Apr 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorBo EgorBo EgorBo approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers
Projects
None yet
Milestone
17.7 P1
Development

Successfully merging this pull request may close these issues.
5 participants
@sharwell @AlekseyTs @EgorBo @jcouv @dibarbet