Don't provide CodeActionWithDialog if option service is null #67951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
Cosifne
commented
Apr 25, 2023
| @@ -113,9 +113,13 @@ public override async Task ComputeRefactoringsAsync(CodeRefactoringContext conte | |||
| GetExistingMemberInfo( | |||
| containingType, out var hasEquals, out var hasGetHashCode); | |||
|
|
|||
| var globalOptions = document.Project.Solution.Services.GetService<ILegacyGlobalOptionsWorkspaceService>(); | |||
sharwell
reviewed
Apr 25, 2023
| @@ -113,9 +113,13 @@ public override async Task ComputeRefactoringsAsync(CodeRefactoringContext conte | |||
| GetExistingMemberInfo( | |||
| containingType, out var hasEquals, out var hasGetHashCode); | |||
|
|
|||
| var globalOptions = document.Project.Solution.Services.GetService<ILegacyGlobalOptionsWorkspaceService>(); | |||
There was a problem hiding this comment.
❓ Is it possible to leverage #66798 instead?
There was a problem hiding this comment.
Oh I don't know this service exists
There was a problem hiding this comment.
I don't see it provides reading these values
It seems like it has a fall back of CodeCleanUpOptions, but the values used here are not part of it, like
https://sourceroslyn.io/#Microsoft.CodeAnalysis.Workspaces/Options/ILegacyGlobalOptionsWorkspaceService.cs,ebbb686a0c6361c3,references
sharwell
approved these changes
Apr 25, 2023
Cosifne
changed the title
arunchndr
approved these changes
Apr 25, 2023
Cosifne
force-pushed
the
dev/shech/checkGlobalOption
branch
from
4d7535c
to
74db2aa
Compare
Cosifne
changed the title
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
GenerateEqualsAndGetHashCodeFromMembersCodeRefactoringProvider.cs)is callingGetRequiredService()forILegacyGlobalOptionsWorkspaceServiceThis would fail in the LSP scenario, because
ILegacyGlobalOptionsWorkspaceServiceis not guaranteed to be there.Updates:
I also modify theIPickMemberServiceusage here. It is also needed to be non-null.This turn outs to be a bigger work, need to modify a lot of tests. Will do later