-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix up implementation for parameterless requests. #68077
Conversation
What would be the best way to test this? Apparently this code path is not tested right now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (pending the test)
{ | ||
public static VoidReturn Instance = new(); | ||
public static NoValue Instance = new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find anyone else using this, so this might not need a dual insertion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's internal, so shouldn't be used, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe everyone using this has IVTs
The only way I know is to create a mock client in unit test, and find a scenario and test it. but it depends on if you could find a lsp scenario hitting this |
@dibarbet Tests added. |
No description provided.