Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequiresNonDocumentChangesTag to ProjectOptionsChangeAction #68160

Merged
merged 1 commit into from
May 11, 2023

Conversation

Cosifne
Copy link
Member

@Cosifne Cosifne commented May 10, 2023

ProjectOptionsChangeAction is used by UpdateProjectToAllowUnsafeCodeFixProvider and UpgradeProjectCodeFixProvider
I think they add AllowUnsafe or change the LanguageVersion in the project file.
Both are not allow in LSP now

@Cosifne Cosifne requested a review from a team as a code owner May 10, 2023 20:36
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 10, 2023
@Cosifne Cosifne changed the title Add RequiresNonDocumentChangesTag to project Add RequiresNonDocumentChangesTag to ProjectOptionsChangeAction May 10, 2023
@Cosifne Cosifne enabled auto-merge May 10, 2023 21:41
@Cosifne Cosifne merged commit 63019e9 into dotnet:main May 11, 2023
@ghost ghost added this to the Next milestone May 11, 2023
@Cosifne Cosifne modified the milestones: Next, 17.7 P2 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants