Drop source suppressed diagnostics in LSP pull diagnostic handler #68333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the regression introduced by dotnet#68287 Addresses part of [AB#1824321](https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1824321) We now drop source suppressed diagnostics from being returned by the LSP pull diagnostics handler. #1824321 tracks potentially updating the LSP spec/clients to allow source suppressed diagnostics to be returned from LSP server to support IDE features for source suppressed diagnostics in LSP pull diagnostics mode.
dotnet-issue-labeler
bot
added
Area-Analyzers
untriaged
davidwengier
approved these changes
May 26, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression introduced by #68287
Addresses part of AB#1824321
We now drop source suppressed diagnostics from being returned by the LSP pull diagnostics handler. #1824321 tracks potentially updating the LSP spec/clients to allow source suppressed diagnostics to be returned from LSP server to support IDE features for source suppressed diagnostics in LSP pull diagnostics mode.