Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add assertions for shape of possibly intercepted call #68447

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Add assertions for shape of possibly intercepted call #68447

merged 4 commits into from
Jun 9, 2023

Conversation

RikkiGibson
Copy link
Contributor

@RikkiGibson RikkiGibson commented Jun 5, 2023 •
edited
Loading

Test plan: #67421

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Jun 5, 2023
@RikkiGibson RikkiGibson changed the base branch from main to features/interceptors June 5, 2023 20:08
@RikkiGibson RikkiGibson marked this pull request as ready for review June 9, 2023 20:13
@RikkiGibson RikkiGibson requested a review from a team as a code owner June 9, 2023 20:13
@RikkiGibson RikkiGibson requested review from cston and jcouv June 9, 2023 20:13
@jcouv jcouv self-assigned this Jun 9, 2023
jcouv
jcouv approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 4)

@RikkiGibson RikkiGibson merged commit 0386fd6 into dotnet:features/interceptors Jun 9, 2023
@RikkiGibson RikkiGibson deleted the assert-call-shape branch June 9, 2023 21:12
@allisonchou allisonchou mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cston cston cston approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels
Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RikkiGibson @cston @jcouv