Enable Binskim scan in CI builds #69081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ghost
added
the
Community
16 tasks
|
@dotnet/roslyn-infrastructure PTAL |
|
I converted it to draft because we uncovered a few questions regarding binskim that we should clear out before enabling the scan. Sorry for the noise |
|
@dotnet/roslyn-infrastructure please have a look |
genlu
approved these changes
Jul 27, 2023
genlu
removed
Community
|
@genlu can you please merge the PR because I can't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling BinSkim scan over build artifacts in CI based on company requirements.
This change is dependent on arcade version update: #69016
We are required to run SDL tools on official builds and implement automated bug filling for the tools output. Currently we are running SDL checks over the source code in the nightly builds, inline in the builds for some of the product repos and in the .NET staging pipeline, but to be compliant we need to also run BinSkim over the produced artifacts.
This PRs is enabling BinSkim checks in the Run SDL tool job of
dotnet-roslyn CIMore information is in the Automate BinSkim runs over official builds issue